RN: Export EventEmitter in Public API#55190
Closed
yungsters wants to merge 2 commits intofacebook:mainfrom
Closed
Conversation
|
@yungsters has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90786781. |
Summary: Removes an obsolete `$FlowFixMe` and removes an unused type argument. Differential Revision: D90785969
Summary: Makes `EventEmitter` (and the related `IEventEmitter` interface type) available as part of React Native's Public API. This allows product logic using React Native to also leverage the same abstraction. Currently, code outside of React Native that wants to use `EventEmitter` must resort to deep imports (which is discouraged). Changelog: [General][Added] - Added `EventEmitter` to `react-native` exports. Differential Revision: D90786781
777a638 to
dcaf50b
Compare
|
This pull request has been merged in f7cd8c4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Makes
EventEmitter(and the relatedIEventEmitterinterface type) available as part of React Native's Public API.This allows product logic using React Native to also leverage the same abstraction. Currently, code outside of React Native that wants to use
EventEmittermust resort to deep imports (which is discouraged).Changelog:
[General][Added] - Added
EventEmittertoreact-nativeexports.Differential Revision: D90786781